Project

General

Profile

Feature #39451

mgr/dashboard: Interlock `fast-diff` and `object-map`

Added by Patrick Seidensal 4 months ago. Updated 4 days ago.

Status:
Resolved
Priority:
Normal
Category:
dashboard/rbd
Target version:
Start date:
04/24/2019
Due date:
% Done:

90%

Source:
Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Pull request ID:

Description

Original title: Can't create RBD image without fast-diff feature

Steps to reproduce:

1. When creating an image, unselect the `fast-diff` flag
2. Create the image
3. Click on the newly created image to check the flags enabled on that image

Additional information:

The POST request of the frontend to the backend did not contain the fast-diff flag, it could be a backend issue.


Related issues

Related to rbd - Feature #24065: [fast-diff] interlock object-map/fast-diff features together Resolved 05/09/2018
Related to rbd - Bug #39521: Fast-diff can be disabled w/o disabling object-map Resolved 04/29/2019
Related to mgr - Bug #39933: mgr/dashboard: inconsistent result when editing a RBD image's features Resolved 05/15/2019
Copied to mgr - Backport #40659: nautilus: mgr/dashboard: Interlock `fast-diff` and `object-map` Resolved

History

#1 Updated by Patrick Seidensal 4 months ago

  • Category set to dashboard/rbd

#2 Updated by Patrick Seidensal 4 months ago

  • Status changed from New to In Progress

#3 Updated by Patrick Seidensal 4 months ago

  • Status changed from In Progress to Feedback
  • Assignee deleted (Patrick Seidensal)

It seems that both, backend and frontend work correctly. The backend does not receive the fast-diff feature flag if it wasn't set on the frontend. Nevertheless, the image is create with the fast-diff feature enabled.

user@ceph-1 /ceph (wip-pna-fix-rbd-image-fast-diff*) $ nc localhost 55555
> /ceph/src/pybind/mgr/dashboard/controllers/rbd.py(246)_create()
-> feature_bitmask = format_features(features)
(Pdb) ll
> /ceph/src/pybind/mgr/dashboard/controllers/rbd.py(37)_rbd_call()
-> func(ioctx, *args, **kwargs)
> /ceph/src/pybind/mgr/dashboard/controllers/rbd.py(246)_create()
-> feature_bitmask = format_features(features)
241                 if obj_size and obj_size > 0:
242                     l_order = int(round(math.log(float(obj_size), 2)))
243
244                 import rpdb; debugger = rpdb.Rpdb(port=55555); debugger.set_trace()
245                 # Set features
246  ->             feature_bitmask = format_features(features)
247
248                 rbd_inst.create(ioctx, name, size, order=l_order, old_format=False,
249                                 features=feature_bitmask, stripe_unit=stripe_unit,
250                                 stripe_count=stripe_count, data_pool=data_pool)
251                 RbdConfiguration(pool_ioctx=ioctx, image_name=name).set_configuration(configuration)
(Pdb) rbd
<module 'rbd' from '/ceph/build/lib/cython_modules/lib.3/rbd.cpython-37m-x86_64-linux-gnu.so'>
(Pdb) features
['deep-flatten', 'layering', 'exclusive-lock', 'object-map']
(Pdb) n
> /ceph/src/pybind/mgr/dashboard/controllers/rbd.py(248)_create()
-> rbd_inst.create(ioctx, name, size, order=l_order, old_format=False,
(Pdb) feature_bitmask
45
(Pdb) c

user@ceph-1 /ceph (wip-pna-fix-rbd-image-fast-diff*) $

#4 Updated by Patrick Seidensal 4 months ago

  • Related to Feature #24065: [fast-diff] interlock object-map/fast-diff features together added

#5 Updated by Lenz Grimmer 4 months ago

  • Related to Bug #39521: Fast-diff can be disabled w/o disabling object-map added

#6 Updated by Patrick Seidensal 4 months ago

  • Status changed from Feedback to In Progress
  • Assignee set to Patrick Seidensal

#7 Updated by Patrick Seidensal 3 months ago

  • Tracker changed from Bug to Feature
  • Subject changed from mgr/dashboard: Can't create RBD image without fast-diff flag to mgr/dashboard: Interlock `fast-diff` and `object-map`

#8 Updated by Patrick Seidensal 3 months ago

  • Status changed from In Progress to Need Review
  • % Done changed from 0 to 90
  • Pull request ID set to 28076

#9 Updated by Patrick Seidensal 3 months ago

  • Description updated (diff)

#10 Updated by Patrick Seidensal 3 months ago

  • Related to Bug #39933: mgr/dashboard: inconsistent result when editing a RBD image's features added

#11 Updated by Lenz Grimmer about 2 months ago

  • Status changed from Need Review to Pending Backport
  • Target version set to v15.0.0
  • Backport set to nautilus

#12 Updated by Nathan Cutler about 2 months ago

  • Copied to Backport #40659: nautilus: mgr/dashboard: Interlock `fast-diff` and `object-map` added

#13 Updated by Ricardo Marques 4 days ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF