Project

General

Profile

Feature #24065

[fast-diff] interlock object-map/fast-diff features together

Added by Jason Dillaman almost 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Since we only support Jewel and later releases, which both support object-map and fast-diff, enabling/disabling object-map should always enable/disable fast-diff.


Related issues

Related to Dashboard - Feature #39451: mgr/dashboard: Interlock `fast-diff` and `object-map` Resolved
Related to rbd - Bug #39521: Fast-diff can be disabled w/o disabling object-map Resolved 04/29/2019

History

#1 Updated by Mao Zhongyi almost 3 years ago

Hi, Jason

I implemented this feature. Please review it.
Thank you very much.

The URL: https://patchwork.kernel.org/patch/10394187/

#2 Updated by Mao Zhongyi almost 3 years ago

Mao Zhongyi wrote:

Hi, Jason

I implemented this feature. Please review it.
Thank you very much.

The URL: https://patchwork.kernel.org/patch/10394187/

Submit this patch by PR.
URL: https://github.com/ceph/ceph/pull/21969.

#3 Updated by Jason Dillaman almost 3 years ago

  • Status changed from New to Resolved

#4 Updated by Patrick Seidensal about 2 years ago

  • Related to Feature #39451: mgr/dashboard: Interlock `fast-diff` and `object-map` added

#5 Updated by Ricardo Marques about 2 years ago

In Nautilus, I cannot create an image with `object-map` and without `fast-diff` because `object-map` will now implicitly enable `fast-diff`, but after creating the image I can disable the `fast-diff` explicitly using the `rbd disable` feature and end up with an image with `object-map` enabled and `fast-diff` disabled. Is this the excepted behaviour or is this a bug?

#6 Updated by Ricardo Marques about 2 years ago

My main question here is, from a Ceph Dashboard point of view, can we simply drop the `fast-diff` checkbox from the RBD form, or do we still have to show the `fast-diff` checkbox when user is editing an image, so he is able to disable `fast-diff` only?

#7 Updated by Jason Dillaman about 2 years ago

@Ricardo: it sounds like a bug if you can disable fast-diff and leave object-map enabled. The dashboard should probably just show "object-map/fast-diff" as a single checkbox. The only trouble I can think of is if you have a legacy image w/ just "object-map" enabled, how would the dashboard show this partial state? Given that, perhaps it would be better if they are kept separate but checking/unchecking one dynamically checks/unchecks the other.

#8 Updated by Jason Dillaman about 2 years ago

Opened tracker ticket #39521

#9 Updated by Lenz Grimmer about 2 years ago

  • Related to Bug #39521: Fast-diff can be disabled w/o disabling object-map added

Also available in: Atom PDF