Ceph » mgr » Dashboard

Dan Guo wrote:

Pls assign this issue to me, and I will complete it as soon as possible.

Great! Done. Thanks for your offer to help.

Ju Lim wrote:

- It would be nice if the selection used a cyan/blue selection vs. underline to be consistent with the rest of the application.

complete, Pls see attach and give me advice.

- If there are a lot of OSDs in a crush map bucket, e.g. ceph(host) in this example, when user scrolls it will be hard for user to know which crush map bucket the OSD belongs to. It would be good to have some way to outline the selection, i.e. ceph(host) and it's children, when it's expanded to know what's in the bucket itself.

Sorry for I have not found a good method to solve this problem after I investigated 'ng2-tree'. I still trying on it. Maybe someone has a good idea and I am very happy to hear it.

- In the table, it would be nice if the status, e.g. "up" had the same visualization as the tree on the left (to be consistent with other table views showing status).

Done, Pls check the attach and give me advice.

- In the table on the right, is it possible for the name, id, and type to be higher up in the table? It just seems odd not to see property/config info of the selected item towards the top of the table.

As I knew, all the table which data has the format of key-value have been sorted by the 'key' before rendered. So, I just add a 'legend' title above the metadata table, like did in the monitor table page.

Hi Dan, thank you so much for looking into this, much appreciated.

Dan Guo wrote:

- It would be nice if the selection used a cyan/blue selection vs. underline to be consistent with the rest of the application.

complete, Pls see attach and give me advice.

Looks good to me!

- If there are a lot of OSDs in a crush map bucket, e.g. ceph(host) in this example, when user scrolls it will be hard for user to know which crush map bucket the OSD belongs to. It would be good to have some way to outline the selection, i.e. ceph(host) and it's children, when it's expanded to know what's in the bucket itself.

Sorry for I have not found a good method to solve this problem after I investigated 'ng2-tree'. I still trying on it. Maybe someone has a good idea and I am very happy to hear it.

If there's no immediate solution, let's tackle this aspect in a separate PR.

- In the table, it would be nice if the status, e.g. "up" had the same visualization as the tree on the left (to be consistent with other table views showing status).

Done, Pls check the attach and give me advice.

I actually like this better than having it in the data table, but I would suggest to put the status behind the name, not in front of it - what do others think?

- In the table on the right, is it possible for the name, id, and type to be higher up in the table? It just seems odd not to see property/config info of the selected item towards the top of the table.

As I knew, all the table which data has the format of key-value have been sorted by the 'key' before rendered. So, I just add a 'legend' title above the metadata table, like did in the monitor table page.

Looks good. Would it be possible to filter out the redundant rows from the table then? Just to reduce the clutter and to avoid displaying duplicate information.