Bug #15260
closed
ceph-disk and ceph-detect-init builds do check-only things on every build
Added by Dan Mick about 8 years ago.
Updated almost 3 years ago.
Description
It seems that ceph-disk and ceph-detect-init's Makefiles always create the virtualenv, whether called during make or make check, but it seems that it only needs the virtualenv for testing (when called during check).
I'm not 100% certain of the fix here but it would be nice if only the ceph-disk-install-data target were run on non-check builds.
We noticed this when the virtualenv construction was failing because of long paths and #! truncation, which prompted the question "why is a non-check build even doing this?"
- Assignee set to Loïc Dachary
Loic, if you could clarify intent and requirements, I'm not necessarily asking you to fix it, but assigning just to get your attention on it
We're not currently using virtualenv during make. But we should, at least for tox -e flake8. I think removing the build dependency to virtualenv would go in the wrong direction. If anything we'll need virtualenv more and more moving foward. Not less and less.
I'm not saying to remove the dependency; I'm saying that it's not necessary outside the test build.
(and even more so that it runs every build, whether anything's changed or not)
I think we should run flake8 on build.
I would support that enhancement
It's fine to run flake8 on build, but can we not use tox or a virtualenv, and use python-flake8 from the distro instead?
That would reduce the complexity of the build considerably.
- Assignee deleted (
Loïc Dachary)
It is not necessary to install tox to run flake8. This can easily be done with the flake8 system package.
Running virtualenv everywhere every time is a burden
- Assignee set to Loïc Dachary
Please create an RFE to run flake8 on builds, but stop creating the virtualenv for non-test builds.
- Status changed from New to Fix Under Review
- Status changed from Fix Under Review to 12
- Assignee deleted (
Loïc Dachary)
- Assignee set to Loïc Dachary
- Assignee deleted (
Loïc Dachary)
I don't know how to fix this, someone else will have to work on it.
- Status changed from 12 to New
- Status changed from New to Won't Fix
Also available in: Atom
PDF