Ceph » Orchestrator

I think a requirements for future refactorization here is:

• having a vera good pytest coverage with example outputs form the different tools and versions.
• read the PR 35491

I think there are a couple of things that we need to change in our approach
1. Don't inspect the containers, and exec the containers to pick up ceph version
2. use the ps -a approach to gather the bulk of the info that we need in one hit
3. add the ceph version information back within the mgr module. The mgr modules have access to all of the ceph versions for every daemon, so we don't need to exec into the containers at all
4. put more stringent version dependencies on docker/podman to ensure the output we need is consistent. This narrows the testing effort, and has the potential of reducing code complexity that old and new versions of podman/docker may reveal.

I'll add a link here to a gist for people to try. By adopting the above approach the ls command on my physical test system (10 osds, mon, mgr, prometheus, node-exporter, alertmanager etc goes from 10s to .5s.

here's the gist https://gist.github.com/pcuzner/c8940e4af5f817b817640e97bff50e91

to test, just download to a ceph host and run (it will pick the first fsid it finds in /var/lib/ceph)

image_id is visible from podman but not docker - so I've excluded from the o/p for consistency. I don't think we actually need image_id for the orchestrator and UI interactions

ceph_version is also missing. Getting it without a label on the container is the main issue with the elapsed time of the existing code. My suggestion is that we don't supply it in the 'ls' output at all. The call to 'ls' is from orch, which is a mgr module, so the ceph metadata can be added to the 'ls' data, back in the mgr/cephadm code.

If we can keep the runtime low, we can run the 'ls' more frequently - perhaps like a prometheus scrape (every 10s!).

PR submitted

PR closed without merge. cephadm exporter merge has made this change less important. Focus needs to be on exploiting the exporter.