Bug #14365
closed
unsafe handle_config_change() methods
Added by Josh Durgin over 8 years ago.
Updated about 8 years ago.
Description
The handle_conf_change() methods in these files look potentially unsafe (modifying data without locks):
client/Client.cc
mds/StrayManager.cc
- Assignee set to John Spray
I think these should be okay, but it's easy to fix. John, can you establish that we don't need locks or else set them up? (Not sure if I'm missing something in the stray manager's locking path.)
- Status changed from New to In Progress
Turns out there's a pre-existing lock cycle issue similar to #14374 here, we just never noticed because live config changes are untested for the most part.
Also, MDSDaemon::handle_conf_change was broken because it was taking mds_lock, when mds_lock is already taken in the handle_command path that's calling into injectargs.
- Status changed from In Progress to Fix Under Review
- Status changed from Fix Under Review to Resolved
Also available in: Atom
PDF