Bug #14374
MDS asok handlers trigger lock cycle assertion if they take mds_lock
0%
Description
http://pulpito.ceph.com/gregf-2016-01-12_23:29:42-fs-greg-fs-speculative---basic-mira/26556
The asok handler is correct to be taking the lock, but it's in conflict with initialization where we do MDSDaemon::mds_lock -> AdminSocket::m_lock.
There are other commands that take the lock (i.e. we already had a bug, but the new status command gets called frequently enough to expose it, whereas the others not so).
Associated revisions
mds: Fix lock ordering around asok registration
Because we acquire mds_lock inside asok handlers,
we must not hold mds_lock while registering our commands.
Fixes: #14374
Signed-off-by: John Spray <john.spray@redhat.com>
mds: Fix lock ordering around asok registration
Because we acquire mds_lock inside asok handlers,
we must not hold mds_lock while registering our commands.
Fixes: #14374
Signed-off-by: John Spray <john.spray@redhat.com>
History
#1 Updated by John Spray about 8 years ago
- Status changed from New to Fix Under Review
#2 Updated by Zheng Yan about 8 years ago
- Status changed from Fix Under Review to Resolved