Bug #46566
closedoctopus: mgr/dashboard: fix rbdmirroring dropdown menu
Added by Avan Thakkar almost 4 years ago. Updated about 3 years ago.
0%
Description
Block -> RBD mirroring: "Edit site name" (top-rightmost button), when clicked, opens a drop-down menu with spans out of the visible screen (it's not cropped, but requires the user to manually scroll the screen to the right).
Files
| Screenshot from 2020-07-16 16-17-22.png (8.01 KB) Screenshot from 2020-07-16 16-17-22.png | Avan Thakkar, 07/16/2020 10:47 AM |
Updated by Avan Thakkar almost 4 years ago
- File deleted (
rbd_mirroring_menu_too_right.png)
Updated by Avan Thakkar almost 4 years ago
- Subject changed from mgr/dashboard: fix rbdmirroring dropdown menu to mgr/dashboard: octopus: fix rbdmirroring dropdown menu
Updated by Avan Thakkar almost 4 years ago
Avan Thakkar wrote:
Block -> RBD mirroring: "Edit site name" (top-rightmost button), when clicked, opens a drop-down menu with spans out of the visible screen (it's not cropped, but requires the user to manually scroll the screen to the right).
Updated by Nathan Cutler almost 4 years ago
@avan thakkar, I noticed you removed the octopus backport, but added "octopus:" to the subject line. That would seem to indicate that the bug exists only in octopus, and not in master. Is that the case? Can you elaborate a bit? (Normally we would try to find which commit(s) fixed the bug in master, and then backport those to octopus....)
Updated by Avan Thakkar almost 4 years ago
Nathan Cutler wrote:
@avan thakkar, I noticed you removed the octopus backport, but added "octopus:" to the subject line. That would seem to indicate that the bug exists only in octopus, and not in master. Is that the case? Can you elaborate a bit? (Normally we would try to find which commit(s) fixed the bug in master, and then backport those to octopus....)
Yes, the issue is reproducible only in octopus and not in master. As the master branch already has dropdown right aligned, so there the issue doesn't happen
Updated by Nathan Cutler almost 4 years ago
Yes, the issue is reproducible only in octopus and not in master. As the master branch already has dropdown right aligned, so there the issue doesn't happen
So would it make sense to:
1. determine which commit/PR (commits/PRs) fixed the issue in master
2. backport those to octopus?
Updated by Nathan Cutler almost 4 years ago
- Subject changed from mgr/dashboard: octopus: fix rbdmirroring dropdown menu to octopus: mgr/dashboard: fix rbdmirroring dropdown menu
- Category set to 152
Updated by Avan Thakkar almost 4 years ago
Nathan Cutler wrote:
Yes, the issue is reproducible only in octopus and not in master. As the master branch already has dropdown right aligned, so there the issue doesn't happen
So would it make sense to:
1. determine which commit/PR (commits/PRs) fixed the issue in master
2. backport those to octopus?
I think the changes in master are due to replacement of ng-bootstrap to ngx- and they haven't been backported yet in octopus. So maybe for now should I just create PR to fix the issue for octopus only?
Updated by Tiago Melo almost 4 years ago
This seems to be the same situations as https://tracker.ceph.com/issues/44458, but in a different part of the frontend.
Since we are not backporting ngx-bootstrap to octopus, this has to be manually fixed in octopus.
Updated by Avan Thakkar almost 4 years ago
- Status changed from New to Fix Under Review
Updated by Lenz Grimmer over 3 years ago
- Status changed from Fix Under Review to Resolved
- Target version set to v15.2.5
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 152 to UX