Cleanup #42310
open
Cleanup #42304: mgr/dashboard: alerts and silences pages improvements
mgr/dashboard: silences: matchers is displayed as JSON object
Added by Patrick Seidensal over 4 years ago.
Updated about 3 years ago.
Description
On the `Silences` page of the dashboard, when selecting a silence, the details of that silence are displayed below in a table:
The `matchers` of the silence are displayed as JSON object. Using a template, this can be prettified.
Files
- Translation missing: en.field_tag_list set to usability, low-hanging-fruit
- Tags deleted (
usability low-hanging-fruit)
This has something to do how our key value table component handles arrays in side objects. It can handle JSON objects but if you have an array inside it it will stringify it's content, as the table doesn't know how to proceed here as it has now clue what the column should be named than.
Matcher.0.name : value
would be an idea here... but if you would do that you would end up with 3*Matchers more columns and I'm not sure if that would be a nicer view.
Stephan Müller wrote:
This has something to do how our key value table component handles arrays in side objects. It can handle JSON objects but if you have an array inside it it will stringify it's content, as the table doesn't know how to proceed here as it has now clue what the column should be named than.
Matcher.0.name : value
would be an idea here... but if you would do that you would end up with 3*Matchers more columns and I'm not sure if that would be a nicer view.
Yeah. How about setting Matchers as a separate division inside the Details with the heading "Matchers" ofcourse, and then separating each Matchers into its own rows. It wont make a big difference or neither a solution to this bug but it would reduce confusion when there are more than 1 matchers as it would be in separate columns.
That would be a fine solution for this bug - as the table used provides an attribute to hide specific attributes :)
Also available in: Atom
PDF