Project

General

Profile

Actions
Copy link

Cleanup #42305

closed

Cleanup #42304: mgr/dashboard: alerts and silences pages improvements

mgr/dashboard: editing silence: order of fields seems unintuitive

Added by Patrick Seidensal over 4 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Nizamudeen A
Category:
Monitoring
Target version:
-
% Done:

50%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:
34511

Description

The creator and comment of a new silence is the first and second field, although they do not seem to be such important. The GUI of the alertmanager also does it differently be presenting the fields `start time`, `duration`, `end time` as well as the matchers prior to the `creator` and `comment` fields. Shouln't we do the same?

Files

Download all files
dashboard_edit_silence.png (65.7 KB) dashboard_edit_silence.png Patrick Seidensal, 10/14/2019 03:39 PM
alertmanager_edit_silence.png (94.1 KB) alertmanager_edit_silence.png Patrick Seidensal, 10/14/2019 03:39 PM
Actions
Copy link
 #1

Updated by Patrick Seidensal over 4 years ago

  • Tags changed from usability to usability low-hanging-fruit
Actions
Copy link
 #2

Updated by Lenz Grimmer over 4 years ago

  • Translation missing: en.field_tag_list set to usability, low-hanging-fruit
  • Tags deleted (usability low-hanging-fruit)
Actions
Copy link
 #3

Updated by Nizamudeen A about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Nizamudeen A
Actions
Copy link
 #4

Updated by Nizamudeen A about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • % Done changed from 0 to 50
  • Pull request ID set to 34511
Actions
Copy link
 #5

Updated by Lenz Grimmer about 4 years ago

  • Backport set to octopus
Actions
Copy link
 #6

Updated by Stephan Müller about 4 years ago

This was done on purpose. So that users can first describe what they will silence and after that add the preferred silence. Also the altermanager uses a different form layout that is not pretty well designed. The form also doesn't have as many validations than our form. When I was implementing the form, I first did it like they had it, than realized there is a better way for us - as in most forms the first field is the name field which in case of a silence is the comment + the creator. That said I'm not in favor of changing it.

Actions
Copy link
 #7

Updated by Nizamudeen A almost 3 years ago

  • Status changed from Fix Under Review to Rejected
Actions
Copy link

Also available in: Atom PDF