Actions
Bug #42179
closedmgr/dashboard: the cross sign button for some modals doesn't work
% Done:
0%
Source:
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
In some modal, the cross-sign button at the upper right side doesn't close the modal.
Example: the confirm modal for moving an image to trash- Create a pool with rbd application
- Create an image on that pool
- Move the image to trash, a modal will be displayed. The upper-right cross sign button doesn't work.
This should be fixed by providing modalRef to <cd-modal> tag (https://github.com/ceph/ceph/blob/c2adfb62c62fb742529f6eb3bf9bccc13dd4efed/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-trash-move-modal/rbd-trash-move-modal.component.html#L1):
<cd-modal> to <cd-modal [modalRef]="modalRef">
Components might be affected (grep with <cd-modal> tag):
# grep '<cd-modal>' * -R ceph/block/iscsi-target-image-settings-modal/iscsi-target-image-settings-modal.component.html:<cd-modal> ceph/block/iscsi-target-iqn-settings-modal/iscsi-target-iqn-settings-modal.component.html:<cd-modal> ceph/block/mirroring/pool-edit-mode-modal/pool-edit-mode-modal.component.html:<cd-modal> ceph/block/mirroring/pool-edit-peer-modal/pool-edit-peer-modal.component.html:<cd-modal> ceph/block/rbd-trash-move-modal/rbd-trash-move-modal.component.html:<cd-modal> ceph/block/rbd-trash-purge-modal/rbd-trash-purge-modal.component.html:<cd-modal> ceph/block/rbd-trash-restore-modal/rbd-trash-restore-modal.component.html:<cd-modal>
Files
Actions