Project

General

Profile

Actions

Cleanup #37337

closed

mgr/dashboard: Consistent labeling for buttons: 'Edit pool' (pool) vs. 'Update RBD' (images) vs. 'Update' (RGW) vs. 'Submit' (Cluster wide flags) ...

Added by Ernesto Puerta over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Low
Category:
General
Target version:
% Done:

0%

Tags:
usability
Backport:
nautilus
Reviewed:
Affected Versions:
Pull request ID:

Description

Buttons for saving Update forms are labelled differently:
  • 'Edit pool' in Pool's editor
  • 'Update RBD' in Image's editor
  • Just 'Update' in RGW users & buckets
  • 'Submit' in OSD cluster-wide flags.
For creation, it kind of happens the same:
  • 'Create Pool/Create RBD' for Pools&Images.
  • Just 'Add' for RGW.
While nothing really burning, I'd try to get a shared label for these. That would also make i18n easier. My bet is just either 'Add/Update' or just 'Submit' for both Add/Edit:
  • 'Edit' is redundant and a bit confusing, since you're already 'editing' the thing.
  • Less is more: 'Update {{whatever}}' does not really add extra info, as the whole UI context tells you what you're updating. And this way you avoid naming inconsistencies like the 'Update RBD' when you are 'Editing an Image'.
  • 'Update' vs. 'Submit': Submit sounds more vintage (web 1.0, aka 'submit a form'), but 'Update' forces you to keep 'Add' and 'Update' (nothing terrible though).

Any thoughts?


Files

current.png (16.6 KB) current.png as per proposed in original Ernesto Puerta, 02/26/2019 08:44 PM
suggestion.png (13.8 KB) suggestion.png new suggestion Ernesto Puerta, 02/26/2019 08:44 PM

Related issues 2 (1 open1 closed)

Related to Dashboard - Bug #41244: mgr/dashboard: Confusing naming of buttons in edit dialogsNewIvo Almeida

Actions
Copied to Dashboard - Backport #39003: nautilus: mgr/dashboard: Consistent labeling for buttons: 'Edit pool' (pool) vs. 'Update RBD' (images) vs. 'Update' (RGW) vs. 'Submit' (Cluster wide flags) ...ResolvedErnesto PuertaActions
Actions

Also available in: Atom PDF