Bug #14962
closed
PG::publish_stats_to_osd() does not get called when trimming snap objects (TestStrays.test_snapshot_remove failure)
Added by Zheng Yan about 8 years ago.
Updated about 8 years ago.
the latest good commit is 82896f2c6e2655db8c9a05a7cc31a9e65c9aa350
- Project changed from CephFS to Ceph
- Subject changed from Failure in TestStrays.test_snapshot_remove to PG::publish_stats_to_osd() does not get called when trimming snap objects
the test expects num_objects in data pool become zero.Due to this bug, it fails.
- Assignee set to Zheng Yan
Is there something tricky about invoking that call when trimming? It'll probably go in faster if you do it and we test through the FS suite first. :)
- Priority changed from Normal to Urgent
if we just trim old snaps, num_object in 'ceph df' does not change (even we wait for a long time). If we create and delete lots of objects (make sure all PG get modified), num_object in 'ceph df' changes immidiately
- Status changed from New to In Progress
- Assignee changed from Zheng Yan to Greg Farnum
Okay, the problem actually got started in cc1b2c6f342b17d6e304560c23f4ce310d6690d9 ("ReplicatedPG: move client reply handling out of eval_repop"), in which the call to publish_stats_to_osd() got moved out of ReplicatedPG::eval_repop and into ReplicatedPG::execute_ctx()'s ctx->register_on_commit() lambda.
But that path is not used for the local ops which trim snapshots, and I think also the path followed in finish_promote(). That leads me to think we just want to unconditionally call publish_stats_to_osd() in ReplicatedPG::eval_repop(), rather than trying to bunch it up with the log_op_stats() call in the execute_ctx() lambda.
- Subject changed from PG::publish_stats_to_osd() does not get called when trimming snap objects to PG::publish_stats_to_osd() does not get called when trimming snap objects (TestStrays.test_snapshot_remove failure)
Updating description with test name so that I can find it on a search
- Assignee changed from Greg Farnum to Samuel Just
- Status changed from In Progress to Resolved
Also available in: Atom
PDF