Bug #14962: PG::publish_stats_to_osd() does not get called when trimming snap objects (TestStrays.test_snapshot_remove failure) - Ceph - Ceph

Custom queries

Backports: mimic
Backports: missing release
Backports: nautilus
Bluestore
Bug queue
Bug queue - no subprojects
Bug triage
Ceph backlog
Crash queue
Crash triage
Feature Requests
Feedback
My issues
Need Review
Pending backports
Priority queue
Product Backlog Scrub
Project Triage
Test Failures

Actions

Copy link

Bug #14962

closed

PG::publish_stats_to_osd() does not get called when trimming snap objects (TestStrays.test_snapshot_remove failure)

Added by Zheng Yan about 8 years ago. Updated about 8 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Samuel Just

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

http://pulpito.ceph.com/zyan-2016-03-02_06:21:11-fs-wip-zyan-testing-testing-basic-mira/37805/

'ceph df' shows the data pool still contains 2 objects. This is OSD issue, it seem that PG::publish_stats_to_osd() is not called when trimming snap objects

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Zheng Yan about 8 years ago

the latest good commit is 82896f2c6e2655db8c9a05a7cc31a9e65c9aa350

Actions

Copy link

Updated by Zheng Yan about 8 years ago

Project changed from CephFS to Ceph
Subject changed from Failure in TestStrays.test_snapshot_remove to PG::publish_stats_to_osd() does not get called when trimming snap objects

the test expects num_objects in data pool become zero.Due to this bug, it fails.

Actions

Copy link

Updated by Greg Farnum about 8 years ago

Assignee set to Zheng Yan

Is there something tricky about invoking that call when trimming? It'll probably go in faster if you do it and we test through the FS suite first. :)

Actions

Copy link

Updated by Samuel Just about 8 years ago

Priority changed from Normal to Urgent

Actions

Copy link

Updated by Zheng Yan about 8 years ago

if we just trim old snaps, num_object in 'ceph df' does not change (even we wait for a long time). If we create and delete lots of objects (make sure all PG get modified), num_object in 'ceph df' changes immidiately

Actions

Copy link

Updated by Greg Farnum about 8 years ago

Status changed from New to In Progress
Assignee changed from Zheng Yan to Greg Farnum

Okay, the problem actually got started in cc1b2c6f342b17d6e304560c23f4ce310d6690d9 ("ReplicatedPG: move client reply handling out of eval_repop"), in which the call to publish_stats_to_osd() got moved out of ReplicatedPG::eval_repop and into ReplicatedPG::execute_ctx()'s ctx->register_on_commit() lambda.

But that path is not used for the local ops which trim snapshots, and I think also the path followed in finish_promote(). That leads me to think we just want to unconditionally call publish_stats_to_osd() in ReplicatedPG::eval_repop(), rather than trying to bunch it up with the log_op_stats() call in the execute_ctx() lambda.

Actions

Copy link

Updated by John Spray about 8 years ago

Subject changed from PG::publish_stats_to_osd() does not get called when trimming snap objects to PG::publish_stats_to_osd() does not get called when trimming snap objects (TestStrays.test_snapshot_remove failure)

Updating description with test name so that I can find it on a search

Actions

Copy link