Feature #12038
closed
I've pushed branch wip-civetwarn to git@github.com:linuxbox2/ceph.git
Yehuda intended to suggest some changes, I don't think he has yet. I've resubmitted it has upstream PR #6944
I did comment on the PR, or on the commit. But I can't find my comments now. Could it be that it got lost due to re-pushing the code?
I've updated PR with what I recall were your original verbal comments:
1. don't warn just because "port" missing
2. refer to upstream feature, not the BZ in the commit msg (and remove comment mentioning it from the code)
- Status changed from New to Fix Under Review
- Assignee set to Matt Benjamin
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #14493: hammer: make rgw_fronends more forgiving of whitespace added
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF