Project

General

Profile

Feature #12038

make rgw_fronends more forgiving of whitespace

Added by Sage Weil over 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
hammer
Reviewed:
Affected Versions:
Pull request ID:

Related issues

Copied to Ceph - Backport #14493: hammer: make rgw_fronends more forgiving of whitespace Resolved

History

#1 Updated by Ken Dreyer over 7 years ago

The original downstream report has a bit more info: https://bugzilla.redhat.com/show_bug.cgi?id=1228845

#2 Updated by Michal Jarzabek over 7 years ago

I can have a look

#4 Updated by Matt Benjamin almost 7 years ago

I've pushed branch wip-civetwarn to :linuxbox2/ceph.git
Yehuda intended to suggest some changes, I don't think he has yet. I've resubmitted it has upstream PR #6944

#5 Updated by Yehuda Sadeh almost 7 years ago

I did comment on the PR, or on the commit. But I can't find my comments now. Could it be that it got lost due to re-pushing the code?

#6 Updated by Matt Benjamin almost 7 years ago

I've updated PR with what I recall were your original verbal comments:
1. don't warn just because "port" missing
2. refer to upstream feature, not the BZ in the commit msg (and remove comment mentioning it from the code)

#7 Updated by Ken Dreyer almost 7 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Matt Benjamin

#8 Updated by Ken Dreyer almost 7 years ago

  • Backport set to hammer

#9 Updated by Ken Dreyer almost 7 years ago

  • Status changed from Fix Under Review to Pending Backport

#10 Updated by Loïc Dachary almost 7 years ago

  • Copied to Backport #14493: hammer: make rgw_fronends more forgiving of whitespace added

#11 Updated by Loïc Dachary almost 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF