Bug #40476
closed
cephfs-shell: cd with no args has no effect
Added by Rishabh Dave almost 5 years ago.
Updated over 4 years ago.
Component(FS):
cephfs-shell
Description
Issuing cd command with no args implies "cd $HOME" in bash but on CephFS shell it has no effect it leads to an error -
CephFS:~/dir1/dir/dir3>>> cd
usage: cd [-h] path
cd: error: the following arguments are required: path
I am not sure if that's what we want on CephFS shell too.
- Status changed from New to Need More Info
- Start date deleted (
06/21/2019)
- Source set to Development
What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).
I'd consider this to be NOTABUG. We don't really have the concept of a home directory in cephfs shell, so why should this do anything? If we did want it to do something though then changing to the root probably makes as much sense as anything.
Patrick Donnelly said:
What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).
master branch. Are you talking about PR #28663? While testing #28663 too I did come across this issue but judging from the commit message I did not feel that th
e commits there were trying to fix it.
I tried it today again and I can still reproduce this issue. Latest commit at the tip of my master is 9d1548bec41dd62793b452a1848dc67d29bb1797.
Rishabh Dave wrote:
Patrick Donnelly said:
What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).
master branch. Are you talking about PR #28663? While testing #28663 too I did come across this issue but judging from the commit message I did not feel that th
e commits there were trying to fix it.
I tried it today again and I can still reproduce this issue. Latest commit at the tip of my master is 9d1548bec41dd62793b452a1848dc67d29bb1797.
It may indeed be broken. It should by default use "/" but maybe the code doesn't work yet. Please make a test case in test_cephfs_shell.py along with a fix. The expected behavior of "cd" should be to chdir to /.
- Pull request ID set to 28793
- Status changed from Need More Info to Fix Under Review
- Assignee set to Rishabh Dave
- Target version set to v15.0.0
- Backport set to nautilus
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #41112: nautilus: cephfs-shell: cd with no args has no effect added
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Also available in: Atom
PDF