Ceph » CephFS

Is this definitely still an issue? I'm not seeing a particular place in the code where we do something different with the mdlog while in clientreplay

It might be fixed; we should check. But once upon a time (I think maybe still now?) then when in clientreplay set the flag that requests an immediate journal flush.

The code that flush journal. https://github.com/ceph/ceph/blob/8ce337e3552004fc4853c0c94f33235da4caa5df/src/mds/Server.cc#L1060 ?

Yeah. So, I think there was a reason for this. We definitely need to flush out any clientreplay requests before exiting clientreplay. But any ops in clientreplay shouldn't be dependent (except within a single-client stream, where we don't care), so our data guarantees should be met just by flushing once before we exit clientreplay. Right?

Or is there some other interaction we need to worry about?