Actions
Bug #8603
closedceph-disk should not hide commands that go through subprocess
% Done:
0%
Source:
other
Tags:
Backport:
firefly
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
ceph-disk currently does not tell you any commands that go through subprocess unless the command
fails, in which case, a python list representation of the command is shown.
This is an easy improvement now that ceph-disk has most (if not all?) subprocess calls going through
subprocess helpers and would make it much easier to see what ceph-disk is doing behind the scenes.
Because ceph-disk does not show DEBUG level logging by default, these commands should be shown at INFO level, otherwise
tools like ceph-deploy would be unable to show them properly as ceph-deploy is still using the old ceph cli helpers that
do not pass in verbosity flags. Like ceph-disk-prepare for example:
#!/bin/sh dir=`dirname $0` $dir/ceph-disk prepare $*
Actions