Bug #7408
closed
filestore xattr use omap = true
Added by Mark Nelson about 10 years ago.
Updated about 10 years ago.
Description
At the core standup yesterday we talked about a really nasty bug where data loss can occur if filestore xattr use omap is not enabled with RGW. A fix is being worked on now for master. In dumpling/ice we are going to enable filestore xattr user omap by default, but we probably need to change the docs to warn people they shouldn't set it to be disabled unless they absolutely know they aren't going to use RGW (and don't need EXT4).
Right now the docs say:
"Use object map for XATTRS. Set to true for ext4 file systems."
http://ceph.com/docs/master/rados/configuration/filestore-config-ref/
I'm not sure if there are other instances where we make similar statements, but we should probably provide at a minimum a warning.
Related bugs:
http://tracker.ceph.com/issues/6143
The change for bug 6143 removed the configuration variable "filestore_xattr_use_omap" The new behavior is just like it were set to true. So the documentation can just remove any mention of that setting. We should create a new tracker if we want to add back this config var.
David Zafman wrote:
The change for bug 6143 removed the configuration variable "filestore_xattr_use_omap" The new behavior is just like it were set to true. So the documentation can just remove any mention of that setting.
Not so much, because that fix was never backported to Dumpling. So for anyone on Dumpling or older, enabling filestore xattr use omap is rather crucial. #6143 has been updated to reflect the missing backport (actually, the missing default flip).
We've generated a couple different tickets about this now that I think are crossing wires, but we're about to backport the necessary bits; David is referring to that future. :)
As I understood Sage what's being done in Dumpling is to flip the default; if so then users still need a warning never to touch the default.
Let's see how we (Sage) decide to resolve #7404. I've created a pull request to backport my 6143 change completely. So that would NOT be just flipping the default. One reason for doing it that way is that it will take additional code to allow you to change the setting from true back to false.
My code has been backported to Dumpling. So the filestore_xattr_use_omap will be gone from the next Dumpling release.
- Status changed from New to Resolved
will be in next dumpling point release.
Also available in: Atom
PDF