Bug #7245
closed
RedHat udev 95-osd-rules file
Added by Derek Yarnell over 10 years ago.
Updated over 10 years ago.
Description
In the RPM spec file there is a test to deploy the uuid hack udev rules for older udev operating systems. This includes Centos and RHEL but the check currently only is for Centos causing RHEL clients to get a bogus osd rules file. Attached is a diff that should fix the issue. New RPMs would need to be built.
Files
Thanks for tracking this down. CentOS's redhat-rpm-config package defines a %{rhel} macro, so I'm thinking we should remove %{centos} here entirely and just use %{rhel}. What do you think?
In other words the diff would be:
-%if 0%{?centos}
+%if (0%{?rhel} && 0%{?rhel} < 7)
- Status changed from New to In Progress
- Assignee set to Ken Dreyer
I agree, I didn't know if CentOS provided this connivence macro or not so I didn't want to assume.
- Status changed from In Progress to Fix Under Review
Proposed here: https://github.com/ceph/ceph/pull/1149
Derek I listed you as the author of the Git commit in order to give you credit, and I added my Signed-off-by line. Please let me know if this looks ok to you.
- Status changed from Fix Under Review to Resolved
to clarify: i think the reason this hasn't caused problems yet is because our el6 packages have been built on centos boxes.
Thanks again, yes we have rebuilt the packages with some changes that didn't land in emperor yet so this is how it bit us.
I checked the 0.75 RPMs to look further into this. http://ceph.com/rpm-testing/rhel6/x86_64/ceph-0.75-0.el6.x86_64.rpm
The 0.75 RPMs were built on a RHEL 6 gitbuilder, and the package also contained the wrong udev file. The 0.75 RPM shipped /lib/udev/rules.d/95-ceph-osd.rules, but the contents were that of udev/95-ceph-osd.rules, when it should have been that of udev/95-ceph-osd-alt.rules.
This RPM macro change will mean that both CentOS 6 and RHEL 6 will ship the same alt.rules file.
Also available in: Atom
PDF