Bug #61819
open
[Client] handle_command_reply overwrite outbl, so cannot get previous results when using wildcard command
Added by Jinmyeong Lee 11 months ago.
Updated 7 months ago.
Description
Sending a command to all MDSs is available in Client:mds_command(https://github.com/ceph/ceph/blob/main/src/client/Client.cc#L6264-L6275) mds_command with mds_spec: *.
The command messages are sharing the bufferlist which is passed by libcephfs::ceph_mds_command.
But in "handle_command_reply", the outbl is overwritten, so to aggregate all results from all MDSs, it should be appended.
Related issues
2 (2 open — 0 closed)
Jinmyeong Lee wrote:
https://github.com/ceph/ceph/pull/52200
I also want to discuss how to append the result in bufferlist.
From now, I just append the result in the bufferlist, but I think the below format would be better. (Also afraid of side-effect)
{
tid_1: [],
tid_2: [],
...
}
- Pull request ID set to 52200
Jinmyeong Lee wrote:
Jinmyeong Lee wrote:
https://github.com/ceph/ceph/pull/52200
I also want to discuss how to append the result in bufferlist.
From now, I just append the result in the bufferlist, but I think the below format would be better. (Also afraid of side-effect)
{
tid_1: [],
tid_2: [],
...
}
Is the `tid_*` prefix the transaction-id? IMO, using mds rank or IDs would be better.
- Status changed from New to Pending Backport
- Backport set to quincy,reef
- Copied to Backport #63147: reef: [Client] handle_command_reply overwrite outbl, so cannot get previous results when using wildcard command added
- Copied to Backport #63148: quincy: [Client] handle_command_reply overwrite outbl, so cannot get previous results when using wildcard command added
- Tags set to backport_processed
Also available in: Atom
PDF