Ceph » mgr » Dashboard

Ernesto Puerta wrote:

$ docker run -ti -v $PWD:/ceph quay.io/centos/centos:stream8 /ceph/install-deps.sh

... that's a great test for our supported distributions. Should that be easy to add as a jenkins test Ernesto?

Patrick Donnelly wrote:

Ernesto Puerta wrote:

$ docker run -ti -v $PWD:/ceph quay.io/centos/centos:stream8 /ceph/install-deps.sh

... that's a great test for our supported distributions. Should that be easy to add as a jenkins test Ernesto?

I like that idea. Based on what I remember, David said most of our Jenkins nodes (at least the Ubuntu ones) didn't have Docker installed, so we should start installing it. We used the #docker Jenkins label to tag those with Docker support.

And at that point we may perhaps consider running a containerized Jenkins job, since Jenkins automatically manages the container. I started this PR a while ago, but never finished. Then John Mulligan took over, but I'm afraid that he didn't reach much further...

If we consider this valuable (testing deps on all our supported platforms per PR), instead of trying to bring total feature parity with make check, we could do that progressively without disabling make check (e.g.: first passing the install-deps.sh stage, after that the configure, etc.). IMHO each individual step brings value because:

• it tests that for every possible platform vs. the current approach that only tests against 1 (random) platform,
• being containerized, it ensures clean & reproducible environments, unlike the ones we have now where we often see CI failures due to environment issues.

Ernesto Puerta wrote:

Patrick Donnelly wrote:

Ernesto Puerta wrote:

$ docker run -ti -v $PWD:/ceph quay.io/centos/centos:stream8 /ceph/install-deps.sh

... that's a great test for our supported distributions. Should that be easy to add as a jenkins test Ernesto?

I like that idea. Based on what I remember, David said most of our Jenkins nodes (at least the Ubuntu ones) didn't have Docker installed, so we should start installing it. We used the #docker Jenkins label to tag those with Docker support.

And at that point we may perhaps consider running a containerized Jenkins job, since Jenkins automatically manages the container. I started this PR a while ago, but never finished. Then John Mulligan took over, but I'm afraid that he didn't reach much further...

That looks really good! Hope it can be picked up again.

If we consider this valuable (testing deps on all our supported platforms per PR), instead of trying to bring total feature parity with make check, we could do that progressively without disabling make check (e.g.: first passing the install-deps.sh stage, after that the configure, etc.). IMHO each individual step brings value because:

• it tests that for every possible platform vs. the current approach that only tests against 1 (random) platform,
• being containerized, it ensures clean & reproducible environments, unlike the ones we have now where we often see CI failures due to environment issues.

agreed