Project

General

Profile

Actions

Bug #57308

closed

Incorrect err pointer casts on Windows

Added by Lucian Petrut over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

100%

Source:
Tags:
Backport:
quincy pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The "long" type uses 32b on x64 Windows platforms, which means it's not large enough to store a pointer. intptr_t or uintptr_t should be used instead.

include/err.h is affected by this issue. There was a previous patch on this topic but unfortunately it didn't address all the type casts.

This was brought up by the unittest_crush test, which recently started to fail as the CrushWrapper methods use IS_ERR.


Related issues 2 (0 open2 closed)

Copied to Ceph - Backport #57402: quincy: Incorrect err pointer casts on WindowsResolvedIlya DryomovActions
Copied to Ceph - Backport #57403: pacific: Incorrect err pointer casts on WindowsResolvedLucian PetrutActions
Actions

Also available in: Atom PDF