Bug #51575
closedmgr/dashboard: Notification banners at the top of the UI have fixed height
0%
Description
The banners, e.g. to notify users to update their password or the enable the telemetry plugin, have a hardcoded fixed height of 37.6px. This makes it impossible to display more than one line in them. Additionally the calculation of the position of ALL components rendered in the navigation component is calculated by the component itself via CSS. This is a not so good approach because actually every component should be repsonsible for itself to calculate and render in the correct height/size. Using a flex layout, e.g. by using @angular/flex-layout component, will fix that. Finally it requires additinal code changes in the navigation component CSS to add another banner; adding <cd-foo></cd-foo> to the navigation HTML should be enough, the rest is done by the flex-layout automatically.
https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/styles/defaults/_bootstrap-defaults.scss#L111
https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.scss#L262
https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts#L103
https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts#L63
As you can see on https://ng-bootstrap.github.io/#/components/alert/examples, the banner automatically increases the height when the view gets to small to display the message in one line. This behaviour is prevented by the current implementation of the navigation component.
Additional references:
https://github.com/angular/flex-layout
Files
Updated by Ernesto Puerta almost 3 years ago
- Status changed from New to Triaged
- Assignee changed from Nizamudeen A to Volker Theile
Volker, can you handle this one?
Updated by Volker Theile over 2 years ago
Ernesto Puerta wrote:
Volker, can you handle this one?
Sorry, i don't think so.
Updated by Ernesto Puerta over 2 years ago
- Status changed from Triaged to Pending Backport
Updated by Backport Bot over 2 years ago
- Copied to Backport #53928: octopus: mgr/dashboard: Notification banners at the top of the UI have fixed height added
Updated by Backport Bot over 2 years ago
- Copied to Backport #53929: pacific: mgr/dashboard: Notification banners at the top of the UI have fixed height added
Updated by Nizamudeen A over 2 years ago
- Related to Bug #53960: mgr/dashboard: navigation page e2e failing added
Updated by Ernesto Puerta about 2 years ago
- Status changed from Pending Backport to Resolved