Project

General

Profile

Actions
Copy link

Bug #50934

closed

Change of public type in snappy

Added by chris denice almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
build
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
42516
Crash signature (v1):
Crash signature (v2):

Description

Just a head-up, the snappy folks just silently made this between version 1.1.8 and 1.1.9 in snappy.h (not even mentioned in the NEWS nor Changelog)

<   bool GetUncompressedLength(Source* source, uint32_t* result);
---
>   bool GetUncompressedLength(Source* source, uint32* result);

The fix:

--- ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h.orig   2021-05-22 21:04:35.132581681 +0200
+++ ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h        2021-05-22 21:04:54.563289389 +0200
@@ -97,7 +97,7 @@
     if (qat_enabled)
       return qat_accel.decompress(p, compressed_len, dst, compressor_message);
 #endif
-    snappy::uint32 res_len = 0;
+    snappy::uint32_t res_len = 0;
     BufferlistSource source_1(p, compressed_len);
     if (!snappy::GetUncompressedLength(&source_1, &res_len)) {
       return -1;

Related issues 1 (0 open — 1 closed)

Copied to Ceph - Backport #51955: pacific: Change of public type in snappyResolvedNathan CutlerActions
Actions
Copy link

Also available in: Atom PDF