Project

General

Profile

Bug #50934

Updated by Nathan Cutler almost 3 years ago

Just a head-up, the snappy folks just silently made this between version 1.1.8 and 1.1.9 in snappy.h (not even mentioned in the NEWS nor Changelog) 

 <pre> 
 <     bool GetUncompressedLength(Source* source, uint32_t* result); 
 --- 
 >     bool GetUncompressedLength(Source* source, uint32* result); 
 </pre> 

 


 The fix: 

 --- ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h.orig     2021-05-22 21:04:35.132581681 +0200 
 +++ ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h          2021-05-22 21:04:54.563289389 +0200 
 @@ -97,7 +97,7 @@ 
      if (qat_enabled) 
        return qat_accel.decompress(p, compressed_len, dst, compressor_message); 
  #endif 
 -      snappy::uint32 res_len = 0; 
 +      snappy::uint32_t res_len = 0; 
      BufferlistSource source_1(p, compressed_len); 
      if (!snappy::GetUncompressedLength(&source_1, &res_len)) { 
        return -1; 

Back