Bug #48041
closed
mgr/cephadm: Allow customizing mgr/cephadm/lsmcli_blink_lights_cmd per host
Added by Volker Theile over 3 years ago.
Updated over 3 years ago.
Description
PR https://github.com/ceph/ceph/pull/36911 introduced a feature to customize the command that is internally used to switch on/off the device LED.
With the current implementation it is not possible to customize the 'lsmcli_blink_lights_cmd' template per host. This would be helpful when not all hosts in the cluster have the same hardware and some of them are not supported by LSM.
Could you mind to explain better the problem?
The blinking light feature is to use with individual storage devices. For example:
- ceph device light on <ident>
(you can get ident with "blkid" or "ceph orch device ls" commands.)
- Description updated (diff)
Juan Miguel Olmo Martínez wrote:
Could you mind to explain better the problem?
The blinking light feature is to use with individual storage devices. For example:
- ceph device light on <ident>
(you can get ident with "blkid" or "ceph orch device ls" commands.)
I've adapted the issue text.
The problem is that the template to build the command line to enable/disable the LEDs is using lsmcli command which finally does not support all hardware that is out in the wild. Having the ability to customize the template per host will allow the user to specifically use alternative tools for the HBA on this host.
Getting this alternative tool installed in the OSD or whatever container is a different problem.
- Description updated (diff)
- Backport set to octopus
- Affected Versions v15.2.6 added
- Status changed from New to Fix Under Review
- Pull request ID set to 37901
Volker Theile wrote:
...
The problem is that the template to build the command line to enable/disable the LEDs is using lsmcli command which finally does not support all hardware that is out in the wild. Having the ability to customize the template per host will allow the user to specifically use alternative tools for the HBA on this host.
IMHO: We must say that we only support this hardware:
https://libstorage.github.io/libstoragemgmt-doc/doc/user_guide.html#supported-hardware
and in any case open a tracker to introduce support for more hardware.
To allow the user to introduce commands that we cannot test to make "in the wild" hardware is a very dangerous feature... at least we should warn about thi
Juan Miguel Olmo Martínez wrote:
To allow the user to introduce commands that we cannot test to make "in the wild" hardware is a very dangerous feature... at least we should warn about thi
Juanmi, I also commented this with Volker today, so Sebastian filed this one: https://tracker.ceph.com/issues/48251
- Related to Cleanup #48251: Find a better way to allow customizing the blink_device_light_cmd cmd added
- Status changed from Fix Under Review to Pending Backport
- Status changed from Pending Backport to Resolved
- Target version deleted (
v16.0.0)
Also available in: Atom
PDF