Project

General

Profile

Bug #44877

mgr/dashboard: allow custom dashboard grafana url when set by cephadm

Added by Sebastian Wagner 4 months ago. Updated 22 days ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
dashboard/backend
Target version:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

The dashboard has grafana-api-url set to https://host:3000. I want to set it to https://host.domain.tld:3000, but my change gets revoked every time!

Right now, there is no chance to set the dashboard's grafana url to the FQDN:

https://github.com/ceph/ceph/blob/4d5fa9317d17975f361d0fa00d73a135f0934b67/src/pybind/mgr/cephadm/module.py#L2529-L2544

See https://github.com/ceph/ceph/pull/34592#issuecomment-638050392 for an explanation why this is required.


Related issues

Related to Orchestrator - Bug #45092: granfana api url - cephadm Duplicate

History

#1 Updated by Sebastian Wagner 4 months ago

  • Priority changed from Normal to High

#2 Updated by Sebastian Wagner 4 months ago

  • Tags set to low-hanging-fruit

#3 Updated by Sebastian Wagner 4 months ago

  • Category changed from cephadm to cephadm/monitoring

#4 Updated by Daniel Pivonka 4 months ago

  • Assignee set to Daniel Pivonka

#5 Updated by Sage Weil 4 months ago

1. A cephadm option to not set the grafana url, so we can avoid making the problem worse, and allow the user to set the dashboard setting themselves.
2. A per-host fqdn property (along-side addr and name). This way dashboard configuration will update if grafana gets moved. Downside is that maybe there is a cert to use that doesn't match the host fqdn.
3. ?

#6 Updated by Sebastian Wagner 4 months ago

  • Status changed from New to In Progress

#7 Updated by Sebastian Wagner 4 months ago

  • Related to Bug #45092: granfana api url - cephadm added

#8 Updated by Sebastian Wagner 4 months ago

  • Assignee changed from Daniel Pivonka to Sebastian Wagner

#9 Updated by Sebastian Wagner 4 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34592

#10 Updated by Sebastian Wagner 2 months ago

  • Project changed from Orchestrator to mgr
  • Subject changed from cephadm: allow custom dashboard grafana url to mgr/dashboard: allow custom dashboard grafana url when set by cephadm
  • Description updated (diff)
  • Category changed from cephadm/monitoring to dashboard/backend
  • Status changed from Fix Under Review to New
  • Assignee deleted (Sebastian Wagner)
  • Tags deleted (low-hanging-fruit)

#11 Updated by Kiefer Chang about 2 months ago

https://github.com/ceph/ceph/blob/3f7b7b658b642f0976a4de0f1d40633fac1c86ce/src/pybind/mgr/cephadm/module.py#L250-L255

Set `config_dashboard` option to False and cephadm won't manage the Dashboard options.

#12 Updated by Adam King about 1 month ago

  • Assignee set to Adam King

#13 Updated by Adam King about 1 month ago

  • Status changed from New to Fix Under Review
  • Pull request ID changed from 34592 to 35747

#14 Updated by Kefu Chai 28 days ago

  • Status changed from Fix Under Review to Resolved

#15 Updated by Sebastian Wagner 22 days ago

  • Target version set to v15.2.5

Also available in: Atom PDF