Project

General

Profile

Actions
Copy link

Bug #44877

closed

mgr/dashboard: allow custom dashboard grafana url when set by cephadm

Added by Sebastian Wagner about 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Adam King
Category:
General - Back-end
Target version:
Ceph - v15.2.5
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
35747
Crash signature (v1):
Crash signature (v2):

Description

The dashboard has grafana-api-url set to https://host:3000. I want to set it to https://host.domain.tld:3000, but my change gets revoked every time!

Right now, there is no chance to set the dashboard's grafana url to the FQDN:

https://github.com/ceph/ceph/blob/4d5fa9317d17975f361d0fa00d73a135f0934b67/src/pybind/mgr/cephadm/module.py#L2529-L2544

See https://github.com/ceph/ceph/pull/34592#issuecomment-638050392 for an explanation why this is required.

Related issues 1 (0 open — 1 closed)

Related to Orchestrator - Bug #45092: granfana api url - cephadmDuplicate

Actions
Actions
Copy link
 #1

Updated by Sebastian Wagner about 4 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #2

Updated by Sebastian Wagner about 4 years ago

  • Tags set to low-hanging-fruit
Actions
Copy link
 #3

Updated by Sebastian Wagner about 4 years ago

  • Category changed from cephadm to cephadm/monitoring
Actions
Copy link
 #4

Updated by Daniel Pivonka about 4 years ago

  • Assignee set to Daniel Pivonka
Actions
Copy link
 #5

Updated by Sage Weil about 4 years ago

1. A cephadm option to not set the grafana url, so we can avoid making the problem worse, and allow the user to set the dashboard setting themselves.
2. A per-host fqdn property (along-side addr and name). This way dashboard configuration will update if grafana gets moved. Downside is that maybe there is a cert to use that doesn't match the host fqdn.
3. ?

Actions
Copy link
 #6

Updated by Sebastian Wagner about 4 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Sebastian Wagner about 4 years ago

  • Related to Bug #45092: granfana api url - cephadm added
Actions
Copy link
 #8

Updated by Sebastian Wagner about 4 years ago

  • Assignee changed from Daniel Pivonka to Sebastian Wagner
Actions
Copy link
 #9

Updated by Sebastian Wagner about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34592
Actions
Copy link
 #10

Updated by Sebastian Wagner almost 4 years ago

  • Project changed from Orchestrator to mgr
  • Subject changed from cephadm: allow custom dashboard grafana url to mgr/dashboard: allow custom dashboard grafana url when set by cephadm
  • Description updated (diff)
  • Category changed from cephadm/monitoring to 146
  • Status changed from Fix Under Review to New
  • Assignee deleted (Sebastian Wagner)
  • Tags deleted (low-hanging-fruit)
Actions
Copy link
 #11

Updated by Kiefer Chang almost 4 years ago

https://github.com/ceph/ceph/blob/3f7b7b658b642f0976a4de0f1d40633fac1c86ce/src/pybind/mgr/cephadm/module.py#L250-L255

Set `config_dashboard` option to False and cephadm won't manage the Dashboard options.

Actions
Copy link
 #12

Updated by Adam King almost 4 years ago

  • Assignee set to Adam King
Actions
Copy link
 #13

Updated by Adam King almost 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID changed from 34592 to 35747
Actions
Copy link
 #14

Updated by Kefu Chai almost 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #15

Updated by Sebastian Wagner almost 4 years ago

  • Target version set to v15.2.5
Actions
Copy link
 #16

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 146 to General - Back-end
Actions
Copy link

Also available in: Atom PDF