Project

General

Profile

Actions
Copy link

Cleanup #44811

closed

mgr/dashboard: Reduce component's style size

Added by Tiago Melo about 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Tiago Melo
Category:
General
Target version:
-
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:
34283

Description

There are 5 components that are importing `styles.scss` file.
This is creating a 200KB css file for each component.
By fixing this we will reduce the build size in around 1MB and the build time in around 5+ seconds

This was caught when running prod build with Angular 9:

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table-actions/table-actions.component.scss. Budget 6 kB was not met by 34.9 kB with a total of 40.9 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/info-card/info-card.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/health/health.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.scss. Budget 6 kB was not met by 188 kB with a total of 194 kB.

Related issues 2 (0 open — 2 closed)

Precedes Dashboard - Feature #44829: mgr/dashboard: Upgrade Angular to v9ResolvedTiago Melo

Actions
Copied to Dashboard - Backport #45895: octopus: mgr/dashboard: Reduce component's style sizeResolvedLaura PaduanoActions
Actions
Copy link
 #1

Updated by Tiago Melo about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Tiago Melo about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34283
Actions
Copy link
 #3

Updated by Tiago Melo about 4 years ago

Actions
Copy link
 #4

Updated by Tiago Melo about 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #5

Updated by Laura Paduano almost 4 years ago

  • Copied to Backport #45895: octopus: mgr/dashboard: Reduce component's style size added
Actions
Copy link
 #6

Updated by Lenz Grimmer almost 4 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to octopus
Actions
Copy link
 #7

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link
 #8

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions
Copy link

Also available in: Atom PDF