Project

General

Profile

Actions
Copy link

Backport #45895

closed

octopus: mgr/dashboard: Reduce component's style size

Added by Laura Paduano almost 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Laura Paduano
Target version:
Ceph - v15.2.4
Release:
octopus
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/35291

Related issues 1 (0 open — 1 closed)

Copied from Dashboard - Cleanup #44811: mgr/dashboard: Reduce component's style sizeResolvedTiago Melo

Actions
Actions
Copy link
 #1

Updated by Laura Paduano almost 4 years ago

  • Copied from Cleanup #44811: mgr/dashboard: Reduce component's style size added
Actions
Copy link
 #2

Updated by Laura Paduano almost 4 years ago

  • Description updated (diff)
  • Status changed from Resolved to In Progress
Actions
Copy link
 #3

Updated by Tiago Melo almost 4 years ago

  • Subject changed from mgr/dashboard: Reduce component's style size to octopus: mgr/dashboard: Reduce component's style size
Actions
Copy link
 #4

Updated by Nathan Cutler almost 4 years ago

  • Description updated (diff)

original description

There are 5 components that are importing `styles.scss` file.
This is creating a 200KB css file for each component.
By fixing this we will reduce the build size in around 1MB and the build time in around 5+ seconds

This was caught when running prod build with Angular 9:

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table-actions/table-actions.component.scss. Budget 6 kB was not met by 34.9 kB with a total of 40.9 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/info-card/info-card.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/health/health.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.scss. Budget 6 kB was not met by 188 kB with a total of 194 kB.

Actions
Copy link
 #5

Updated by Yuri Weinstein almost 4 years ago

Laura Paduano wrote:

https://github.com/ceph/ceph/pull/35291

merged

Actions
Copy link
 #6

Updated by Nathan Cutler almost 4 years ago

  • Status changed from In Progress to Resolved
  • Target version set to v15.2.4

This update was made using the script "backport-resolve-issue".
backport PR https://github.com/ceph/ceph/pull/35291
merge commit 9486312ce5384688c484a5d60529c22fb76d438f (v15.2.3-447-g9486312ce53)

Actions
Copy link
 #7

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
Actions
Copy link

Also available in: Atom PDF