Project

General

Profile

Tasks #40748

mgr/dashboard: Automate merging pull requests using Mergify

Added by Lenz Grimmer almost 2 years ago. Updated about 1 year ago.

Status:
Rejected
Priority:
Low
Assignee:
-
Category:
dashboard/general
Target version:
-
% Done:

0%

Tags:
Reviewed:
Affected Versions:
Pull request ID:

Description

This was brought up during today's stand-up: the process of merging pending github pull requests should be fully automated. This removes the bottleneck of having an individual performing this task manually.

There is a third-party service called Mergify that could be utilized for this.

We should evaluate the functionality and define a workflow that would make sense for the majority of Dashboard PRs to pass through this workflow without manual interaction.

Some things to consider: how to deal with tests that fail quite frequently, e.g. make check on ARM64? How about QA tests that are triggered and checked manually? What are the risks of automating the final step of merging a PR?

Automate_1allthethings.png View (484 KB) Lenz Grimmer, 07/12/2019 09:03 AM

History

#1 Updated by Lenz Grimmer almost 2 years ago

FWIW, the ceph-ansible project already uses Mergify for performing merges and backports

#2 Updated by Kiefer Chang almost 2 years ago

It will be nice if the tool can also handle situations like one PR can only be merged after another one is merged.
Or at least the tool can provide some exception rules to be defined: for example, a PR with DNM label should not be merged automatically.

#3 Updated by Ernesto Puerta over 1 year ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 29496

#4 Updated by Ernesto Puerta about 1 year ago

  • Status changed from Fix Under Review to Rejected

Also available in: Atom PDF