Project

General

Profile

Actions
Copy link

Bug #39653

closed

mgr/dashboard: Error cloning RBD image without 'layering' feature enabled

Added by Ricardo Marques almost 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Ricardo Marques
Category:
Component - RBD
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
29317
Crash signature (v1):
Crash signature (v2):

Description

Only RBD images with 'layering' feature enabled can be cloned, but Ceph Dashboard is not validating this, so the user will see a generic error:

Ceph Dashboard should validate if the parent image has the 'layering' feature enabled, and display the corresponding validation message.

Files

clone_without_layering_error.png (57.6 KB) clone_without_layering_error.png Ricardo Marques, 05/09/2019 02:28 PM
Actions
Copy link
 #1

Updated by Patrick Seidensal almost 5 years ago

  • Tags set to low-hanging-fruit
Actions
Copy link
 #2

Updated by Lenz Grimmer almost 5 years ago

  • Translation missing: en.field_tag_list set to usability, low-hanging-fruit
  • Tags deleted (low-hanging-fruit)
Actions
Copy link
 #3

Updated by Lenz Grimmer almost 5 years ago

As discussed in the backlog grooming call today, the frontend should check if the layering feature is enabled and disable the "Clone RBD" button, if it's not (displaying a tooltip or giving some other visual hint on why cloning is not possible).

In general, the dashboard should prevent the user from running into errors before the action will be performed.

Actions
Copy link
 #4

Updated by Ricardo Marques almost 5 years ago

Ideally, we should display a "disableDesc" in the Clone action, similar to what was done in PR https://github.com/ceph/ceph/pull/28260

Actions
Copy link
 #5

Updated by Ricardo Marques almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Ricardo Marques
Actions
Copy link
 #6

Updated by Ricardo Marques almost 5 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 29317
Actions
Copy link
 #7

Updated by Lenz Grimmer over 4 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.0.0

Fixed for Octopus (15.0.0) now. Please speak up if you think this ought to be fixed in Nautilus as well.

Actions
Copy link
 #8

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 139 to Component - RBD
Actions
Copy link

Also available in: Atom PDF