Project

General

Profile

Bug #39653

mgr/dashboard: Error cloning RBD image without 'layering' feature enabled

Added by Ricardo Marques 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Category:
dashboard/rbd
Target version:
Start date:
05/09/2019
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

Only RBD images with 'layering' feature enabled can be cloned, but Ceph Dashboard is not validating this, so the user will see a generic error:

Ceph Dashboard should validate if the parent image has the 'layering' feature enabled, and display the corresponding validation message.

clone_without_layering_error.png View (57.6 KB) Ricardo Marques, 05/09/2019 02:28 PM

History

#1 Updated by Patrick Seidensal 6 months ago

  • Tags set to low-hanging-fruit

#2 Updated by Lenz Grimmer 6 months ago

  • Tags set to usability, low-hanging-fruit
  • Tags deleted (low-hanging-fruit)

#3 Updated by Lenz Grimmer 6 months ago

As discussed in the backlog grooming call today, the frontend should check if the layering feature is enabled and disable the "Clone RBD" button, if it's not (displaying a tooltip or giving some other visual hint on why cloning is not possible).

In general, the dashboard should prevent the user from running into errors before the action will be performed.

#4 Updated by Ricardo Marques 4 months ago

Ideally, we should display a "disableDesc" in the Clone action, similar to what was done in PR https://github.com/ceph/ceph/pull/28260

#5 Updated by Ricardo Marques 3 months ago

  • Status changed from New to In Progress
  • Assignee set to Ricardo Marques

#6 Updated by Ricardo Marques 3 months ago

  • Status changed from In Progress to Need Review
  • Pull request ID set to 29317

#7 Updated by Lenz Grimmer 3 months ago

  • Status changed from Need Review to Resolved
  • Target version set to v15.0.0

Fixed for Octopus (15.0.0) now. Please speak up if you think this ought to be fixed in Nautilus as well.

Also available in: Atom PDF