Feature #37086
closed
Add several flags to ceph-volume lvm batch
Added by Jan Fajerski over 5 years ago.
Updated over 4 years ago.
Description
as discussed in several orchestrator meetings, the batch subcommand needs several arg additions.
-replace-osd-ids=previous_osd_ids # comma separated list. See notes below
--objectstore={filestore,bluestore}
--dmcrypt
--osds-per-device <N>
--shared-device <dev> # for hybrid osds, db or journal
--num-slots <N> # if we want to divide shared device by N > num devices
--shared-underprovision-ratio <ratio>
--dmcrypt, --objectstore, and --osds-per-device are already supported
I don't think that --num-slots or --shared-underprovision are needed since we support --journal-size and --block-db-size, that can be set to whatever number so that shared devices can be
underutilized
- Status changed from New to In Progress
- Assignee set to Jan Fajerski
I had a look into the batch subcommand. The current argument stucture (with data devices as positional arguments and --bluestore/--filestore as optional) it's not possible to add arguments like --wal-devices while keeping existing functionality as is.
I decided to add an optional subcommand objectstore. By default this is empty and results in batch behaving like it does today. Otherwise it can either be bluestore or filestore. This allows for new functionality being implemented without impacting existing users, as well as for proper separation between bluestore-only and filestore-only arguments.
The development branch is here https://github.com/jan--f/ceph/tree/c-v-extend-batch
AFAICT this was merged into master. Do you plan backports into mimic and luminous?
I believe so. I'm happy to provide the PRs, though its ultimately up to Andrew Schoen when those will land.
@Jan: Provide the master PR ID number as well?
- Copied to Backport #40919: mimic: Add several flags to ceph-volume lvm batch added
- Pull request ID set to 25542
- Status changed from In Progress to Pending Backport
- Backport set to mimic, nautilus
- Copied to Backport #40954: nautilus: Add several flags to ceph-volume lvm batch added
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF