Project

General

Profile

Actions

Cleanup #36563

closed

mgr/dashboard: Improve SummaryService's getCurrentSummary method

Added by Tiago Melo over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
General
Target version:
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently this method will return the value of the summary, even if we haven't receive any.
If you call this method expecting to have some data, you code will probably fail or do nothing.

I propose we return an observable, that will only be resolved when we have some data.
Then, in our code, we could subscribe to this and be sure it would always work.

This could be applied to all situation where we are subscribing to the summary and immediately unsubscribe after we get some data.
For example, when determining the releaseName.


Related issues 1 (0 open1 closed)

Copied to Dashboard - Backport #45855: octopus: mgr/dashboard: Improve SummaryService's getCurrentSummary methodResolvedTiago MeloActions
Actions

Also available in: Atom PDF