Project

General

Profile

Feature #24651

mgr/dashboard: Improve SSL certificate import to no longer require a Mgr restart

Added by Lenz Grimmer over 1 year ago. Updated about 1 month ago.

Status:
Rejected
Priority:
Normal
Category:
dashboard/general
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Now that https://github.com/ceph/ceph/pull/22634 has been merged into master, the process for importing SSL certificates into the dashboard module commands should be improved to no longer require restarting the Ceph Manager. According to John Spray, we need to "implement new commands in the dashboard module to accept the certificate input, and then in the handle_command function consume the inbuf field."


Related issues

Related to mgr - Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modules New

History

#1 Updated by Dan Mick over 1 year ago

Here's an unmerged example, called directly from handle_command():

    def do_post(self, cmd, inbuf):
        try:
            metadata = Module.validate_crash_metadata(inbuf)
        except Exception as e:
            return errno.EINVAL, '', 'malformed crash metadata: %s' % e

        crashid = metadata['crash_id']
        key = 'crash/%s' % crashid
        if self.get_store(key):
            return errno.EADDRINUSE, '', 'crash id %s already saved' % crashid

        self.set_store(key, inbuf)
        return 0, '', 'Posted %s' % crashid

#2 Updated by Sebastian Wagner over 1 year ago

  • Assignee changed from Lenz Grimmer to Sebastian Wagner

#3 Updated by Sebastian Wagner over 1 year ago

  • Status changed from New to In Progress

#4 Updated by Sebastian Wagner over 1 year ago

After investigating a bit:

  1. Reloading just the CherryPy engine is not implemented.
  2. enabling or disabling any module from within a module is not possible.

Maybe it's possible to run execv ourselves?

#6 Updated by Sebastian Wagner over 1 year ago

  • Related to Bug #24648: 'ceph mgr enable/disable <module>' interrupts all other modules added

#7 Updated by Lenz Grimmer about 1 year ago

  • Status changed from In Progress to New
  • Pull request ID set to 23447

This is currently on hold - the pending PR was closed due to lack of activity.

#8 Updated by Sebastian Wagner about 1 month ago

  • Status changed from New to Rejected

We cannot (And will likely never be able to) properly restart modules, therefore let's close this issue as rejected. Relates to https://github.com/ceph/ceph/pull/32051

Also available in: Atom PDF