Project

General

Profile

Bug #24648

'ceph mgr enable/disable <module>' interrupts all other modules

Added by Ernesto Puerta 9 months ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
ceph-mgr
Target version:
-
Start date:
06/25/2018
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
ceph-qa-suite:
Pull request ID:

Description

Adding or removing Ceph Mgr Modules interrupts all other modules. While this might have minimal impact with background/long-running modules, for user-facing ones like Ceph Dashboard, it results, for example, in the users becoming logged out.

Steps (v13.0.0-v14.y.z):
- Log to Ceph Dashboard
- Enable new module: ceph mgr module enable hello
- All users logged/working on the Ceph dashboard will be automatically logged out.

Log traces confirm that on enable/disable, the ceph-mgr process is respawned and hence all Python modules are reloaded. This seems to come from the Active/Standby Mgr logic, so the question would be whether a change in the MgrMap for module enabling/disabling should trigger this logic (or what kind of issue this behaviour is trying to deal with).


Related issues

Related to mgr - Feature #36237: mgr/dashboard: Add support for managing Ceph Mgr modules New 09/27/2018
Related to mgr - Feature #24651: mgr/dashboard: Improve SSL certificate import to no longer require a Mgr restart New 06/25/2018

History

#1 Updated by John Spray 9 months ago

Modules should try not to be too sensitive to mgr daemon restarts -- remember that these will also happen during e.g. upgrades.

The current behaviour of restarting on module enable/disable is just for simplicity/robustness. If it does seem worthwhile to implement dynamic activation of modules without a restart, then I would recommend still to keep the restart behaviour when a module is *dis*abled -- I'd rather not be worrying about how to handle a buggy module that e.g. doesn't shut down promptly.

#2 Updated by Ernesto Puerta 9 months ago

Thanks for the feedback, John. Paul Cuzner mentioned this behaviour today and I just wanted to have it recorded for any future action.

#3 Updated by Lenz Grimmer 6 months ago

  • Related to Feature #36237: mgr/dashboard: Add support for managing Ceph Mgr modules added

#4 Updated by Lenz Grimmer 6 months ago

Note: there is an open pull request that will change the dashboard authentication scheme to using JWT tokens, which supposedly would resolve the "session loss at mgr restart" problem for the dashboard. But this is not fixing the root cause that the mgr performs a restart of all modules every time a module is enabled or disabled.

#5 Updated by Sebastian Wagner 5 months ago

  • Related to Feature #24651: mgr/dashboard: Improve SSL certificate import to no longer require a Mgr restart added

#6 Updated by Sebastian Wagner 5 months ago

This affects #24651, as there is no way to properly restart just the dashboard module.

Also available in: Atom PDF