Feature #2290
closed
ObjectCacher: handle read/write errors
Added by Josh Durgin about 12 years ago.
Updated almost 12 years ago.
Description
Currently the return value of the underlying read/write calls is ignored (I left TODO notes there). We should figure out the best way to handle these (mark buffer with the error and return it on next use? return error on next flush? something else?)
- Translation missing: en.field_position set to 1
- Translation missing: en.field_position deleted (
1)
- Translation missing: en.field_position set to 61
- Translation missing: en.field_position deleted (
74)
- Translation missing: en.field_position set to 22
- Translation missing: en.field_position deleted (
26)
- Translation missing: en.field_position set to 10
- Translation missing: en.field_story_points set to 8
- Translation missing: en.field_position deleted (
19)
- Translation missing: en.field_position set to 19
- Target version set to v0.47
- Translation missing: en.field_position deleted (
19)
- Translation missing: en.field_position set to 12
- Status changed from New to In Progress
- Assignee set to Josh Durgin
- Status changed from In Progress to Fix Under Review
Forgot to update this before, but it's in wip-oc-error-handling.
This looks okay to me, although I didn't check it for comprehensive-ness (just looked at the diff).
- Status changed from Fix Under Review to In Progress
Sage actually reviewed this a while ago, and I was changing it to separate the read/write errors and not return the write errors for reads.
- Target version changed from v0.47 to v0.48
- Status changed from In Progress to Fix Under Review
Updated wip-oc-error-handling to use a separate BufferHead state for read errors, and just reset the state to dirty on write errors.
- Status changed from Fix Under Review to Resolved
- Translation missing: en.field_position deleted (
34)
- Translation missing: en.field_position set to 40
- Target version changed from v0.48 to v0.47
- Translation missing: en.field_position deleted (
40)
- Translation missing: en.field_position set to 1
- Translation missing: en.field_position changed from 1 to 1251
Also available in: Atom
PDF