Ceph

the package name here is CryptoPP, not cryptopp, which all letters are lower-case

The package name is CryptoPP in which distribution? In openSUSE, for example, the package name appears to be libcryptopp.

https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1

Nathan Cutler wrote:

the package name here is CryptoPP, not cryptopp, which all letters are lower-case

The package name is CryptoPP in which distribution? In openSUSE, for example, the package name appears to be libcryptopp.

https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1

Hi, it's no matter how the system name the library. Actually the file Findcryptopp.cmake is to find the library in different distributions.

The problem here is how to name it in cmake file. If you use CryptoPP in FIND_PACKAGE_HANDLE_STANDARD_ARGS(cmake func), then you should name the module file with FindCryptoPP.cmake, and use CryptoPP in find_package(cmake func). Or use lower-case all the places.

@Shengjing Zhu: Thanks for the explanation. Opened a PR with a fix - please review.

Nathan Cutler wrote:

@Shengjing Zhu: Thanks for the explanation. Opened a PR with a fix - please review.

Thanks for your fix, after a quick look and grep locally,

in cmake/modules/Findrdma.cmake, it uses a different library name

./Findrdma.cmake:find_package_handle_standard_args(ibverbs DEFAULT_MSG RDMA_LIBRARIES RDMA_INCLUDE_DIR)

Maybe it's also a mistake