Bug #19497
closed
osd_scrub_sleep option blocks op thread in jewel + later
Added by Josh Durgin about 7 years ago.
Updated over 6 years ago.
Description
Just like snap trimming, when scrubbing was moved into the unified op queue, its sleep option was not changed, so it now blocks osd ops rather than just pausing scrubbing.
This sleep should be moved from PG::scrub() into the scrub state machine, and made async, just like it was for snap trimming - see http://tracker.ceph.com/issues/19241
- Assignee set to Brad Hubbard
- Status changed from New to In Progress
- Status changed from In Progress to Pending Backport
- Copied to Backport #20032: jewel: osd_scrub_sleep option blocks op thread in jewel + later added
- Copied to Backport #20033: kraken: osd_scrub_sleep option blocks op thread in jewel + later added
@Brad - yes, when you open the backport PR, just mention both backport tracker issues in the commit message ;-)
I say "when you open" because I looked at the cherry pick of PR#14886 to jewel. . . and it's non-trivial. It conflicts, e.g., with https://github.com/ceph/ceph/commit/b7e77996586daa46da6be0bfbb8c2b93e203a83a and I don't know if that's a dependency.
Can I assign the backport trackers to you?
@Nathan Weinberg, Yes mate, please do and I'll see what I can do about it. b7e77996586daa46da6be0bfbb8c2b93e203a83a shouldn't be a dependency but it's also my code so I'm definitely best placed to do the work :)
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF