Project

General

Profile

Actions

Bug #18163

closed

platform.linux_distribution() is deprecated; stop using it

Added by Tim Serong over 7 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

platform.linux_distribution() is deprecated, so we should stop using it. Notably it uses /etc/SuSE-release on SUSE systems, and the latest SUSE versions don't ship this file; instead they ship /etc/os-release, which platform.linux_distribution() doesn't know about, so it returns ('','','').

AFAICT, platform.linux_distribution() is currently used by ceph-detect-init, which in turn is used by ceph-disk. If ceph-detect-init can't determine the distro because it sees ('','',''), this results in ceph-disk always tagging the init system as sysvinit.

There are also platform.linux_distribution() invocations in qa/workunits/ceph-disk/ceph-disk-no-lockbox and src/ceph-disk/ceph_disk/main.py, but they look like dead code to me.

See also bug #18141


Related issues 2 (0 open2 closed)

Has duplicate devops - Bug #23781: ceph-detect-init still uses python's platform libDuplicate04/18/2018

Actions
Copied to Ceph - Backport #39277: luminous: platform.linux_distribution() is deprecated; stop using itResolvedNathan CutlerActions
Actions

Also available in: Atom PDF