Project

General

Profile

Actions

Bug #13991

closed

osd: fix ScrubJob compare function

Added by Xinze Chi over 8 years ago. Updated over 8 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If we not consider the deadline in compare function. Some pgs would not
be scheduled when the deadline arrives.

Such as, there is ScrubJob A in sched_scrub_pg. A.pgid = 1.1, A.sched_time = 0:00,
A.deadline = 23:00. Now we send a command ceph pg scrub 1.2, so osd would
add a new ScrubJob B. It is possible that B.pgid = 1.2, A.sched_time = 0:00,
A.deadline = 0:00. Current strategy ScrubJob B would be scheduled after A.
But A.deadline is much later than B.deadline. So it possible that job B is
not scheduled when the job B deadline arrives.

Actions

Also available in: Atom PDF