Project

General

Profile

Bug #13709

init script reload doesn't work on EL7

Added by Herve Rousseau about 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
hammer, infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Checked on ceph-radosgw-0.94.5-0.el7.centos.x86_64:

# /etc/init.d/ceph-radosgw reload
Reloading ceph-radosgw configuration (via systemctl):  Job for ceph-radosgw.service failed. See 'systemctl status ceph-radosgw.service' and 'journalctl -xn' for details.
                                                           [FAILED]

This is because in the reload case, killproc $RADOSGW -SIGHUP is handled by sh's built-in kill which doesn't understand -SIGHUP

  • Output of the init script with -x
    Nov 06 09:36:33 cephrgwd01.cern.ch ceph-radosgw[31731]: + kill -SIGHUP 31250
    Nov 06 09:36:33 cephrgwd01.cern.ch ceph-radosgw[31731]: + RC=1
    Nov 06 09:36:33 cephrgwd01.cern.ch ceph-radosgw[31731]: + '[' 1 -eq 0 ']'
    Nov 06 09:36:33 cephrgwd01.cern.ch ceph-radosgw[31731]: + failure 'radosgw -SIGHUP'
    Nov 06 09:36:33 cephrgwd01.cern.ch ceph-radosgw[31731]: + local rc=1
    
  • Manual confirmation of the issue:
    sh-4.2# kill -SIGHUP `pidof radosgw`
    sh: kill: SIGHUP: invalid signal specification
    sh-4.2# kill -HUP `pidof radosgw`
    sh-4.2# echo $?
    0
    sh-4.2#
    

There's a pull request coming to fix this.


Related issues

Copied to rgw - Backport #13830: infernalis: init script reload doesn't work on EL7 Resolved
Copied to rgw - Backport #13831: hammer: init script reload doesn't work on EL7 Resolved

Associated revisions

Revision 1b000aba (diff)
Added by Herve Rousseau about 7 years ago

rgw: fix reload on non Debian systems.

When using reload in non-debian systems, /bin/sh's kill is used to send the HUP signal to the radosgw process.
This kill version doesn't understand -SIGHUP as a valid signal, using -HUP does work.

Fix: #13709
Backport: hammer
Signed-off-by: Hervé Rousseau <>

Revision fdb5dbd7 (diff)
Added by Herve Rousseau about 7 years ago

rgw: fix reload on non Debian systems.

When using reload in non-debian systems, /bin/sh's kill is used to send the HUP signal to the radosgw process.
This kill version doesn't understand -SIGHUP as a valid signal, using -HUP does work.

Fix: #13709
Backport: hammer
Signed-off-by: Hervé Rousseau <>
(cherry picked from commit 1b000abac3a02d1e788bf25eead4b6873133f5d2)

Revision f96c8125 (diff)
Added by Herve Rousseau almost 7 years ago

rgw: fix reload on non Debian systems.

When using reload in non-debian systems, /bin/sh's kill is used to send the HUP signal to the radosgw process.
This kill version doesn't understand -SIGHUP as a valid signal, using -HUP does work.

Fix: #13709
Backport: hammer
Signed-off-by: Hervé Rousseau <>
(cherry picked from commit 1b000abac3a02d1e788bf25eead4b6873133f5d2)

History

#2 Updated by Nathan Cutler about 7 years ago

  • Status changed from New to Fix Under Review

#3 Updated by Yehuda Sadeh about 7 years ago

  • Assignee set to Ken Dreyer

#4 Updated by Ken Dreyer about 7 years ago

  • Assignee changed from Ken Dreyer to Boris Ranto

#5 Updated by Boris Ranto about 7 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport changed from hammer to hammer, infernalis

Merged upstream (master). We should probably back-port this to infernalis as well.

#6 Updated by Abhishek Varshney about 7 years ago

  • Copied to Backport #13830: infernalis: init script reload doesn't work on EL7 added

#7 Updated by Abhishek Varshney about 7 years ago

  • Copied to Backport #13831: hammer: init script reload doesn't work on EL7 added

#8 Updated by Nathan Cutler almost 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF