Bug #11101
ceph tell: broken error message / misleading hinting
0%
Description
Description of problem:
root@master:~# ceph osd tell "osd tell" is deprecated; try "tell osd.<id>" instead (id can be "*") root@master:~# ceph tell osd.* Cannot use 'tell' with interactive mode root@master:~#
Expected results:
I am not in interactive mode!
Besides that, I'd want the hint to point me to something I can try out without further understanding, like
"osd tell" is deprecated; try "tell osd.<id> bench" instead (id can be "*")
"ceph osd tell"
is mentioned in the "top 10 commands" blogs in several places and on the ceph wiki - separately requested a fix there. That gets users started down this path, just like it did me.
Related issues
Associated revisions
ceph.in: print more detailed error message for 'tell' command
- we do not allow user specify a certain daemon when starting an
interactive session. the existing error message could lead to
some confusion. so put more details in it.
Fixes: #11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph.in: print more detailed error message for 'tell' command
- we do not allow user specify a certain daemon when starting an
interactive session. the existing error message could lead to
some confusion. so put more details in it.
Fixes: #11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 972dc9145235ff0f60663369ebcab8c16628b89f)
ceph.in: improve the error message
Fixes: #11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph.in: improve the error message
Fixes: #11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit e19e8f1553fdf8b6b642d3222d28f242fab696f0)
History
#1 Updated by Kefu Chai over 7 years ago
- Description updated (diff)
- Regression set to No
#2 Updated by Kefu Chai over 7 years ago
- Status changed from New to Fix Under Review
- Assignee set to Kefu Chai
#4 Updated by Kefu Chai over 7 years ago
- Status changed from Fix Under Review to Pending Backport
#5 Updated by Loïc Dachary over 7 years ago
- Status changed from Pending Backport to Resolved
#6 Updated by Kefu Chai about 7 years ago
- Status changed from Resolved to Fix Under Review
#7 Updated by Kefu Chai about 7 years ago
per Harish
We need to change the message something like this:
"Ceph 'tell' requires additional arguments. <print usage for tell command>"
#8 Updated by Kefu Chai about 7 years ago
#9 Updated by Kefu Chai about 7 years ago
- Status changed from Fix Under Review to Pending Backport
#10 Updated by Loïc Dachary almost 7 years ago
- Status changed from Pending Backport to Resolved
#11 Updated by Kefu Chai over 6 years ago
- Status changed from Resolved to Pending Backport
@Loïc, https://github.com/ceph/ceph/pull/7106 is not backported yet.
#12 Updated by Nathan Cutler over 6 years ago
Backport of https://github.com/ceph/ceph/pull/7106 :
hammer PR: https://github.com/ceph/ceph/pull/10905
#13 Updated by Nathan Cutler about 6 years ago
- Status changed from Pending Backport to Resolved