Subtask #815
closed
Feature #801: librados: allow access to multiple clusters
Remove globals & partition g_conf
Added by Greg Farnum about 13 years ago.
Updated almost 13 years ago.
Description
This bug is to track the progress of removing globals and setting up g_conf so it can be used as a parameter rather than a global.
So one issue that occurred to me with setting this up is that we have a number of things that really ought to be globals. For instance, right now the SimpleMessenger can take a single Throttler and use that to restrict the flow of incoming and outgoing messages based on config options in g_conf. While it's good to remove the globals, it's entirely possible that clients will have connections to multiple clusters but still want to have a total limit on how much memory is devoted to caching messages. We'll need some way of implementing that!
Good point. Some things probably should be global. However, we have a lot of things that library clients don't want to be global as globals now. That's the problem.
Also, even things that should be global, it's not good to have global constructors that do a lot of work. Global constructor time is scary.
- Target version changed from 12 to v0.26
- Estimated time set to 0:00 h
- Estimated time set to 0:00 h
- Status changed from In Progress to Resolved
- Estimated time set to 0:00 h
This bug was really all about refactoring stuff to be thread-safe. Now, that task has been completed.
It's time to start testing and fixing any issues that were uncovered. That will be done in bug #1257.
Colin.
Also available in: Atom
PDF