Project

General

Profile

Actions

Bug #7262

closed

ceph-disk-activate: custom mount options aren't handled correctly for non-default-named clusters

Added by Josh Durgin about 10 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Mount options are initially read from the hardcoded ceph.conf:

https://github.com/ceph/ceph/blob/d7b0c7faafd37e4ae8a1680edfa60c22b419cbd8/src/ceph-disk#L1592

If this is not a cluster named ceph, these options are used later in move_mount(), or the defaults
are used if no mount options were specified in ceph.conf.

Actions #1

Updated by Kai Zhang about 10 years ago

Hi, I was trying to fix this today. But in my cluster, disk was activated automatically right after ceph-disk-prepare.
When I tried ceph-disk-activate, it said the the disk was mounted already.
I was confused. Can someone explain the magic behide it? Thanks!
The log http://pastebin.com/VUFfVATb
I didn't modify the code.
OS: ubuntu 12.04
ceph: 0.72.2
ceph-deploy:1.3.5

Actions #2

Updated by Josh Durgin about 10 years ago

After the disk are prepared, udev notices the disk label and this rule calls ceph-disk-activate: https://github.com/ceph/ceph/blob/master/udev/95-ceph-osd.rules

Actions #3

Updated by Kai Zhang about 10 years ago

I change the ceph-disk a little bit:
In mount_active, mount the disk using default mount options, then activate it to get the cluster name.
Read the right mount options from {cluster}.conf. Unmount and pass the right options to move_mount

I'm no sure what would happen if using default mount options for activate() temporally. But it works in my cluster.

https://github.com/ceph/ceph/pull/1206

Actions #4

Updated by Loïc Dachary about 9 years ago

  • Status changed from New to 12
  • Priority changed from Normal to High
Actions #5

Updated by Loïc Dachary about 8 years ago

  • Assignee set to Loïc Dachary
Actions #6

Updated by Loïc Dachary over 7 years ago

  • Assignee deleted (Loïc Dachary)
Actions #7

Updated by Samuel Just over 7 years ago

  • Priority changed from High to Normal
Actions #8

Updated by Sage Weil about 7 years ago

  • Status changed from 12 to Resolved
Actions

Also available in: Atom PDF