Project

General

Profile

Actions

Fix #5268

closed

mds: fix/clean up file size/mtime recovery code

Added by Sage Weil almost 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Performance/Resource Usage
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client, MDS, osdc
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

from diagnosing #4832 (see the attached log) it looks like this code needs an overhaul:

  • i don't think we should be triggering recovery when transitioning from stable states, but explicitly sometime earlier
  • we should hold a wrlock while gathering, and avoid the maxsize/size force_wrlock flag at the end
  • we should have well defined behavior for when a client goes stale, resume, stale, etc., and races with file size recovery.

Related issues 1 (1 open0 closed)

Related to CephFS - Feature #4485: Improve "needsrecover" handlingNew03/17/2013

Actions
Actions

Also available in: Atom PDF