Bug #51062: mds,client: suppport getvxattr RPC - CephFS - Ceph

Actions

Copy link

Bug #51062

closed

mds,client: suppport getvxattr RPC

Added by Jeff Layton almost 3 years ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Low

Assignee:

Milind Changire

Category:

Introspection/Control

Target version:

Ceph - v17.0.0

% Done:

100%

Source:

Development

Tags:

Backport:

quincy, pacific

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Client, MDS

Labels (FS):

task(medium)

Pull request ID:

42001

Crash signature (v1):

Crash signature (v2):

Description

Playing with ephemeral pinning today, and found that I can't query ceph.dir.pin.random:

[jlayton@client1 test]$ sudo setfattr -n ceph.dir.pin.random -v 0.5 ephemeral/
[jlayton@client1 test]$ sudo getfattr -n ceph.dir.pin.random  ephemeral/
ephemeral/: ceph.dir.pin.random: No such attribute

Most likely an oversight in the MDS xattr handling.

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Patrick Donnelly almost 3 years ago

Jeff Layton wrote:

Playing with ephemeral pinning today, and found that I can't query ceph.dir.pin.random:

[...]

Most likely an oversight in the MDS xattr handling.

With libcephfs or kclient? We haven't wired these up yet.

Actions

Copy link

Updated by Jeff Layton almost 3 years ago

kclient, but I don't think it matters. This is a server-side xattr, so it comes down to allowing it to be queried via handle_client_getxattr.

Actions

Copy link

Updated by Patrick Donnelly almost 3 years ago

Jeff Layton wrote:

kclient, but I don't think it matters. This is a server-side xattr, so it comes down to allowing it to be queried via handle_client_getxattr.

The main challenge is that we either need to (a) pass these fields back to ht eclient in the inode data in the cap message or (b) develop a new getvxattr RPC just for learning some vxattrs. We keep needing to do (a) so I'm thinking it'd be a useful change to add a getvxattr RPC so only MDS-side changes are required in the future. In particular, this would be very helpful for getting the inherited layout on a directory (we have an open BZ for that somewhere).

Actions

Copy link

Updated by Milind Changire almost 3 years ago

Status changed from New to Triaged
Assignee set to Milind Changire

Actions

Copy link

Updated by Milind Changire almost 3 years ago

Status changed from Triaged to Fix Under Review
Pull request ID set to 42001

Actions

Copy link

Updated by Patrick Donnelly over 2 years ago

Tracker changed from Bug to Feature
Subject changed from ceph.dir.pin.random attribute can't be queried to mds,client: suppport getvxattr RPC
Category set to Introspection/Control
Target version set to v17.0.0
Source set to Development
Component(FS) Client, MDS added
Labels (FS) task(medium) added