Actions
Subtask #5046
closedFeature #4929: Erasure encoded placement group
Factor out PG logs, PG missing
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
OSD
Target version:
-
% Done:
0%
Spent time:
35:00 h (Total: 55:30 h)
Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
PG logs, PG missing: The logic for merging an authoritative PG log with another PG log while filling in the missing set would benefit massively from being testable seperately from a PG instance. It's possible that the stripes involved in ErasureCodedPG will make this impractical to generalize.
- Move log, logondisk, missing from being public data members of PG to being protected data members of PGLog.{cc,h} and adapt the callers accordingly. It improves encapsulation and does not change any of the logic already in place. ( ready for review review take 1 review take 2 review take 3 review take 4 review take 5)
- Define an API for PGLog.{cc,h}
- Write unit tests for PGLog.{cc,h}
Discussions
Actions