Project

General

Profile

Actions

Bug #49238

closed

[rbd-mirror] interrupted image creation might result in unlinked images

Added by Jason Dillaman over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

http://qa-proxy.ceph.com/teuthology/trociny-2021-02-09_07:56:42-rbd-wip-mgolub-testing-distro-basic-smithi/5870969/teuthology.log

In the example above, mirroring was disabled on "image_4" but the remote site failed to delete the image. The rbd-mirror daemon on the remote site noticed the image was no longer mirrored and attempted to remove it, but in "BootstrapRequest<I>::handle_prepare_remote_image", the "is_linked" boolean evaluated to false which prevented returning the error code to indicate the image should be deleted:

remote image does not exist: local_image_id=155ffd1f1dd1, remote_image_id=, is_linked=0

The reason "is_linked" was false was because when retrieving the local mirror info, the promotion state was UNKNOWN because it didn't have a non-primary mirror snapshot available:

handle_get_mirror_info: local_image_id=155ffd1f1dd1, local_promotion_state=0, local_primary_mirror_uuid=

The reason for the missing snapshot was because the snapshot will only be created by "snapshot::Replayer" when performing the initial sync and the rbd-mirror daemon that initially create the image was shut down by the thrasher. Therefore, we either need to delay the updating of the mirror image state to keep it in the CREATING state until the first non-primary snapshot is created, or "librbd::mirror::EnableRequest" needs to create the non-primary snapshot to be pruned later by the replayer.


Related issues 3 (0 open3 closed)

Related to rbd - Bug #56516: [rbd-mirror] bogus "incomplete local non-primary snapshot" replayer errorResolvedIlya Dryomov

Actions
Copied to rbd - Backport #49416: pacific: [rbd-mirror] interrupted image creation might result in unlinked imagesResolvedJason DillamanActions
Copied to rbd - Backport #49417: octopus: [rbd-mirror] interrupted image creation might result in unlinked imagesResolvedJason DillamanActions
Actions #1

Updated by Jason Dillaman over 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 39432
Actions #2

Updated by Mykola Golub about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #3

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49416: pacific: [rbd-mirror] interrupted image creation might result in unlinked images added
Actions #4

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49417: octopus: [rbd-mirror] interrupted image creation might result in unlinked images added
Actions #5

Updated by Loïc Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions #6

Updated by Ilya Dryomov almost 2 years ago

  • Related to Bug #56516: [rbd-mirror] bogus "incomplete local non-primary snapshot" replayer error added
Actions

Also available in: Atom PDF